Pin the CI test badge to the master branch - #766
Merged
Conversation
Without a branch filter the badge reflects the most recent test.yaml run on any branch, including pull_request runs from forks, which always fail because fork PRs receive no OIDC credentials for AWS. Point the badge (and its link) at master so it reports the actual CI status. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Add
?branch=masterto the CI test badge in the README (and point its link at the master-filtered run list).WHY
Without a branch filter, the badge shows the status of the most recent
test.yamlrun on any branch. Fork PRs triggertest.yamlbut receive no OIDC credentials for AWS, so those runs always fail — after merging #763 the README badge showed "failing" even though the latest master run (workflow_dispatch before the v3.36.0 release) succeeded. Pinning the badge to master makes it report the actual CI status.🤖 Generated with Claude Code